feat: schema and related logic grooming (#879)

* feat: change hasCloudLB description
* feat: remove deprecated property

fixes redkubes/unassigned-issues#442

Co-authored-by: Maurice Faber <maurice.faber@redkubes.com>

.cspell.json

@@ -143,6 +143,7 @@
     "sysctls",
     "testmode",
     "textconv",
+    "unencrypted",
     "untrusted",
     "xlarge"
   ]

.values/env/settings.yaml

@@ -1 +1 @@
-version: 3
+version: 4

helmfile.d/snippets/defaults.yaml

@@ -3,7 +3,7 @@ environments:
     values:
       - azure:
           appgw:
-            isManaged: true
+            isManaged: false
         apps:
           alertmanager:
             enabled: false
@@ -155,7 +155,6 @@ environments:
           hasExternalDNS: false
           hasExternalIDP: false
           isHomeMonitored: false
-          isManaged: true
           isMultitenant: false
         teamConfig: {}
         letsencryptRootCA: |

tests/fixtures/env/cluster.yaml

@@ -6,5 +6,5 @@ cluster:
     k8sVersion: '1.22'
     name: demo
     owner: redkubes
-    provider: aws
+    provider: azure
     region: eu-central-1

tests/fixtures/env/settings.yaml

@@ -64,7 +64,6 @@ otomi:
     hasExternalIDP: true
     hasExternalDNS: true
     isHomeMonitored: true
-    isManaged: true
     isMultitenant: true
     version: main
     nodeSelector:

tests/kind/env/settings.yaml

@@ -3,7 +3,6 @@ otomi:
     hasExternalDNS: false
     hasExternalIDP: false
     isHomeMonitored: false
-    isManaged: false
     isMultitenant: true
     version: main
 version: 3

values-changes.yaml

@@ -30,3 +30,6 @@ changes:
     relocations:
       - apps.ingress-nginx.loadBalancerIP: ingress.platformClass.loadBalancerIP
       - apps.ingress-nginx.loadBalancerRG: ingress.platformClass.loadBalancerRG
+  - version: 4
+    deletions:
+      - otomi.isManaged

values-schema.yaml

@@ -1193,8 +1193,8 @@ properties:
       appgw:
         properties:
           isManaged:
-            default: true
-            description: Was the AKS cluster installed with appgw addon?
+            default: false
+            description: Indicates Azure Application Gateway Ingress Controller add-on is installed by AKS.
             type: boolean
       monitor:
         $ref: '#/definitions/azure/definitions/monitor'
@@ -2579,7 +2579,7 @@ properties:
           - password
       hasCloudLB:
         default: false
-        description: 'Set this to true when an external LB exists or needs to be started (AWS ALB, Azure AppGW, Google Apigee). This will then be configured through ingress controllers. Expects existing LBs to terminate https. Currently this is only working correctly for Azure, and not for AWS and Google. AWS is close to completion.'
+        description: "Set this to true when a cloud specific ingress controller is wanted/installed that terminates TLS and forwards traffic unencrypted. Otherwise Otomi's Nginx controller will create a loadbalancer that will take care of this."
         type: boolean
       hasExternalDNS:
         description: Set this to true when an external dns zone is available to manage dns records. (Expects required `dns:` fields to be set.)
@@ -2593,10 +2593,6 @@ properties:
         default: false
         description: Whether this cluster is home monitored (like when under a Premium SLA). Sends criticals home.
         type: boolean
-      isManaged:
-        default: true
-        description: Whether masters are managed and not under control. Set this to false for provider "custom".
-        type: boolean
       isMultitenant:
         default: false
         description: Whether to separate team metrics and logs. Disabling this lets everybody be admin and see everything.