fix: servicemonitor labels #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With regression we lost correct labeling for some servicemonitors. This PR corrects that. |
|
Not an interesting PR to review imo, but important to release soon as half of otomi workloads are now not tracked! |
j-zimnowoda
reviewed
Jun 16, 2022
j-zimnowoda
requested changes
Jun 16, 2022
j-zimnowoda
reviewed
Jun 16, 2022
There was a problem hiding this comment.
Besides that it looks good. I have checked if metrics are visible in Istio Workload and Istio Service dashboard and saw logs for teams and platform service.
If you just remove reference to fixes #626 then we can merge it
|
I think you made an incorrect conclusion about not showing logs, you probably did not view correct time window:
|
Ani1357
pushed a commit
that referenced
this pull request
Oct 25, 2023
also fixed loki regression by adding retention enabled flag, removed unnecessary monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #626
fixes #820