-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more dns providers, including 'other' #889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just few remarks. Looking forward to next iteration. Cheers.
cc92717
to
b48e459
Compare
Fixed also many validation issues which were still quite a lot. |
b48e459
to
9f214c1
Compare
I looked again, only two remarks, related with previous comments |
Could you perform migration tests for values with azure dns settings? |
What do you mean? Unit tests are in place for migration tests. |
external-dns is still an app that allows for raw values as ppl might want to add more filters |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
4062983 | Generic High Entropy Secret | 51a3b08 | tests/fixtures/env/secrets.settings.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
4062983 | Generic High Entropy Secret | 51a3b08 | tests/fixtures/env/secrets.settings.yaml | View secret |
4062983 | Generic High Entropy Secret | 7fb6043 | tests/fixtures/env/secrets.settings.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
* feat: more dns providers, including 'other' Co-authored-by: Jehoszafat Zimnowoda <jehoszafat.zimnowoda@redkubes.com>
Checklist
adr/*.md
and appended to list inadr/_index.md
, if applicable.values-schema.yaml
file andtest/**
fixtures have been updated to reflect code changes, if applicable.values-schema.yaml
file, if applicable.