Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more dns providers, including 'other' #889

Merged
merged 11 commits into from
Sep 12, 2022
Merged

Conversation

Morriz
Copy link
Contributor

@Morriz Morriz commented Aug 26, 2022

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.

@Morriz Morriz requested review from srodenhuis, j-zimnowoda, oshah97 and staticvoid255 and removed request for srodenhuis August 26, 2022 01:15
src/cmd/bootstrap.ts Outdated Show resolved Hide resolved
values-schema.yaml Outdated Show resolved Hide resolved
values-schema.yaml Outdated Show resolved Hide resolved
values-schema.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just few remarks. Looking forward to next iteration. Cheers.

values-schema.yaml Outdated Show resolved Hide resolved
values-schema.yaml Show resolved Hide resolved
values-schema.yaml Show resolved Hide resolved
values-schema.yaml Outdated Show resolved Hide resolved
values-schema.yaml Show resolved Hide resolved
@Morriz
Copy link
Contributor Author

Morriz commented Aug 29, 2022

Fixed also many validation issues which were still quite a lot.
Can you re-review @j-zimnowoda ?

@j-zimnowoda
Copy link
Contributor

Fixed also many validation issues which were still quite a lot.
Can you re-review @j-zimnowoda ?

I looked again, only two remarks, related with previous comments

@j-zimnowoda
Copy link
Contributor

Could you perform migration tests for values with azure dns settings?

@Morriz
Copy link
Contributor Author

Morriz commented Aug 29, 2022

Could you perform migration tests for values with azure dns settings?

What do you mean? Unit tests are in place for migration tests.

@Morriz
Copy link
Contributor Author

Morriz commented Aug 30, 2022

external-dns is still an app that allows for raw values as ppl might want to add more filters

@j-zimnowoda j-zimnowoda self-requested a review August 31, 2022 14:01
values-schema.yaml Show resolved Hide resolved
values-schema.yaml Show resolved Hide resolved
values-schema.yaml Show resolved Hide resolved
@redkubes redkubes deleted a comment from gitguardian bot Sep 5, 2022
@gitguardian
Copy link

gitguardian bot commented Sep 5, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4062983 Generic High Entropy Secret 51a3b08 tests/fixtures/env/secrets.settings.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gitguardian
Copy link

gitguardian bot commented Sep 5, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4062983 Generic High Entropy Secret 51a3b08 tests/fixtures/env/secrets.settings.yaml View secret
4062983 Generic High Entropy Secret 7fb6043 tests/fixtures/env/secrets.settings.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@j-zimnowoda j-zimnowoda self-requested a review September 12, 2022 06:22
@j-zimnowoda j-zimnowoda merged commit 10ed2f8 into main Sep 12, 2022
@j-zimnowoda j-zimnowoda deleted the moz/feat/other-dns branch September 12, 2022 06:25
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
* feat: more dns providers, including 'other'

Co-authored-by: Jehoszafat Zimnowoda <jehoszafat.zimnowoda@redkubes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants