Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: values migration #908

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix: values migration #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa0a479
fix: migrate values before processing them
j-zimnowoda Sep 21, 2022
bed0e87
fix: values migration
j-zimnowoda Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cmd/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ export const bootstrap = async (
const otomiImage = `otomi/core:${tag}`
d.log(`Installing artifacts from ${otomiImage}`)
await deps.copyBasicFiles()

await deps.migrate()
const originalValues = await deps.processValues()
// exit early if `isCli` and `ENV_DIR` were empty, and let the user provide valid values first:
if (!originalValues) {
Expand Down Expand Up @@ -381,7 +381,7 @@ export const bootstrap = async (
'`otomi.adminPassword` has been generated and is stored in the values repository in `env/secrets.settings.yaml`',
)
}
await deps.migrate()

if (!hasOtomi) {
d.log('You can now use the otomi CLI')
}
Expand Down
4 changes: 3 additions & 1 deletion values-changes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ changes:
- otomi.isManaged
- version: 5
deletions:
- istio.autoscaling.ingressgateway-private
- apps.istio.autoscaling.ingressgateway-private
- apps.istio.global.mtls
- apps.istio.global.sds
relocations:
- apps.loki.storageType: apps.loki.storage.storageType
- apps.loki.aws: apps.loki.storage.aws
Expand Down
2 changes: 2 additions & 0 deletions values-schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,6 +2029,8 @@ properties:
external-secrets:
additionalProperties: false
properties:
_rawValues:
$ref: '#/definitions/rawValues'
enabled:
type: boolean
logLevel:
Expand Down