floats aren't parsed correctly.

[SeanTAllen]

Sees

1.1 + 1 = 2.1.

as

1 + 1 = 2.

[brweber2]

In the parser the definition of digits does not allow for non-integers?

DIGITS: ('+'|'-') ? ('0'..'9')+;

Some additional tests for things like 1 + 2.3 might be interesting, but I looked at all the usages of DIGITS and I don't see anywhere in the parser that allows for decimals at all. I'm pretty new to the parser however, so I could be missing something obvious...

[jamesladd]

You are right. The grammars parsing of floats is not correct.
We had a version that was ok with floats but it got lost with one of the many re-writes.
I'll look for it.

[robdaemon]

The decimal is what makes the floats tricky because the . is also the statement terminator. I tried fixing this once but I'm not very good with antlr.

[jamesladd]

I kind of remember that a lex rule wont cut it and we need a parser rule.
Which can swallow up the period when the thing following a period is a
digit.

Guess Ill be reading that ANTLR book a.s.a.p

On Sat, Dec 24, 2011 at 3:40 PM, Robert Roland <
reply@reply.github.com

wrote:

The decimal is what makes the floats tricky because the . is also the
statement terminator. I tried fixing this once but I'm not very good with
antlr.

---

Reply to this email directly or view it on GitHub:

#75 (comment)

[SeanTAllen]

Ditto.

I broke more than I fixed, I had floats working but I introduced lots of other issues.

I also need time to read the ANTLR book.

[SeanTAllen]

fixed with new compiler.