-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding additional configurable options #44
Conversation
tychoish
commented
Mar 2, 2014
- default site author, override-able on a per-post basis
- made the config separator in the post format configurable on a per-site basis
- changed the file migrations to use rsync rather than cp.
- make the build check in the local directory for a config file before falling back to the user-wide config file.
- made "posts" directory configurable
- made output extension configurable, including theoretical support for having extension-less paths (though this requires some corresponding web server configuration)
I believe that these changes are not backward breaking, but I don't have a good way of testing them, so am certainly willing to make changes. Sorry to bundle so much up in one commit. I'm working on migrating a huge site and am trying to get coleslaw up to feature parity, so the hacking isn't very disciplined. |
(setf (content-slug object) (slugify title) | ||
format (make-keyword (string-upcase format)) | ||
text (render-content text format) | ||
author (if author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer (or author (author *config*))
here. I'm also not sure whether I'd prefer the author slot to be on the POST or CONTENT class but I'm okay to leave it on POST for now.
I have one question: It might be a little while before I have time to make these changes, but I'll try to get to this soon. |
@@ -46,8 +52,6 @@ Additional args to render CONTENT can be passed via RENDER-ARGS." | |||
|
|||
(defun compile-blog (staging) | |||
"Compile the blog to a STAGING directory as specified in .coleslawrc." | |||
(when (probe-file staging) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the --delete flag to rsync should achieve the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. Thanks. Depending on rsync is probably okay. Hard to imagine someone running a server without it installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed. rsync is also much faster for multi-file operations
@redline6561, I updated the pull request with your suggestion, modulo one point, which I continued to discuss in the comments. Hope this is useful, of course. |
This looks good. Thanks for your work and your patience shepherding these changes through. :) |
adding additional configurable options