Make i18n messages (preamble of posted conversation) configurable #227
Comments
This configuration should be a client and query builder specific setting. |
The WIdget gets such configurations as I do not want to have such split up in various query builder configurations. IMO it is better to add a separate section for such data to the client configuration and implement an own web service that allows the widget to retrieve this part of the configuration. This would allow to customise also other parts of the widget WDYT? |
Currently these localized preambles are used in the widget: "widget.conversation.answer.title": {
"de":"Ich habe eine passende Konversation gefunden:",
"en":"I found a similar conversation:"
},
"widget.conversation.answer.title_msg": {
"de":"Ich habe eine passende Nachricht gefunden:",
"en":"I found a related message:"
},
"widget.latch.answer.title": {
"de": "Das hab ich dazu in $[1] gefunden:",
"en": "Here is what I found in $[1]:"
} |
For the time being we could change the texts to an empty String. But how can we customize the standard texts without changing the standard distribution? In my opinion, labels etc. should be configurable. |
If we want them to be configureable by client we need to use the Smarti The system wide defaults should be configured as typical for |
Why do we need to create another issue? The title of this issue exactly matches our needs. I will rename it into a more generic description. |
The implementation effects Smarti code only (Webservice + Widget) there is no general Rocket.Chat adoption required. |
|
Why should we make this configurable per client? I expect a system wide configuration to be sufficient. @Peym4n is it already possible to configure the widget‘s i18n without building it? |
@mrsimpson configure |
@mrsimpson currently the i18n data exists as json in the code. |
@Peym4n having it in a separate file will still make it necessary to compile a new Smarti version. Unless it can be injected from the consumer to the widget (e. G. via the constructor or via a session variable), I’d not consider it „configurable“ |
@mrsimpson I'm aware of that. I just wanted the i18n strings to be separate. I wasn't proposing a solution. If anyone has a solution to make these strings configurable across the system I would be happy to implement it. |
What to we try to accomplish here?
I think we need a decision what we are aiming for. |
@mrsimpson The configurable i18n JSON can now be set in the |
As an admin, I want to be a able to edit the preamble of the posted conversation (such as "Ich habe eine passende Konversation gefunden:" or "Das hab ich dazu in gefunden") in a free text field at the Admin interface.
For example, I want to be able to show no preamble in front of the posted conversation or customize the message myself.
The text was updated successfully, but these errors were encountered: