Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imrove the way Feature is created. #9

Open
Jeevuz opened this issue Dec 29, 2021 · 0 comments
Open

Imrove the way Feature is created. #9

Jeevuz opened this issue Dec 29, 2021 · 0 comments

Comments

@Jeevuz
Copy link

Jeevuz commented Dec 29, 2021

I think the usability of the library can be improved if you change

abstract class Feature {
    abstract val id: String
}

to

abstract class FeatureNew(internal val id: String)

So the users will be able to add features like this

object New : FeatureNew("Экран")

instead of this

object Old : Feature() {
    override val id: String = "Экран кэшбека. Отображать персональные предложения"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant