Improvements #4

alabotski · 2020-02-17T07:52:03Z

No description provided.

ghost · 2020-02-17T07:52:17Z

Congratulations 🍻. DeepCode analyzed your code in 0.103 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

AlexOreshkevich

codeCoverageReport was not added to gradle.build

AlexOreshkevich · 2020-02-17T09:35:35Z

BUILD FAILED in 563ms
alexanders-iMac:Projects neo$ cd spring-graphql-microservice/
alexanders-iMac:spring-graphql-microservice neo$ gradle clean build
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Task :employee-client:test

com.rednavis.employee.EmpolyeeGraphQlTest > testFindAll() FAILED
    java.lang.IllegalStateException
        Caused by: org.springframework.beans.factory.BeanCreationException
            Caused by: org.springframework.beans.BeanInstantiationException
                Caused by: javax.ws.rs.ProcessingException
                    Caused by: org.newsclub.net.unix.AFUNIXSocketException

1 test completed, 1 failed

> Task :employee-client:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':employee-client:test'.
> There were failing tests. See the report at: file:///Users/neo/Projects/spring-graphql-microservice/employee-client/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 8s
36 actionable tasks: 29 executed, 7 up-to-date

alabotski · 2020-02-17T14:22:22Z

@AlexOreshkevich
https://github.com/rednavis/spring-graphql-microservice/blob/improvements/build.gradle

codeCoverageReport - already exists

alabotski · 2020-02-17T14:26:40Z

BUILD FAILED in 563ms
alexanders-iMac:Projects neo$ cd spring-graphql-microservice/
alexanders-iMac:spring-graphql-microservice neo$ gradle clean build
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Task :employee-client:test

com.rednavis.employee.EmpolyeeGraphQlTest > testFindAll() FAILED
    java.lang.IllegalStateException
        Caused by: org.springframework.beans.factory.BeanCreationException
            Caused by: org.springframework.beans.BeanInstantiationException
                Caused by: javax.ws.rs.ProcessingException
                    Caused by: org.newsclub.net.unix.AFUNIXSocketException

1 test completed, 1 failed

> Task :employee-client:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':employee-client:test'.
> There were failing tests. See the report at: file:///Users/neo/Projects/spring-graphql-microservice/employee-client/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2m 8s
36 actionable tasks: 29 executed, 7 up-to-date

Can you give me more info?
As you can see jenkins has builed project without any errors

codecov · 2020-02-18T12:10:20Z

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage     15.94%   15.94%           
  Complexity       22       22           
=========================================
  Files            29       29           
  Lines           207      207           
=========================================
  Hits             33       33           
  Misses          174      174

# Conflicts: # README.md

AlexOreshkevich

lgtm

AlexOreshkevich · 2020-03-03T12:30:01Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 21
- Added 26
           

Complexity increasing per file
==============================
- core/src/test/java/com/rednavis/core/CoreModuleTest.java  1
- organization-client/src/test/java/com/rednavis/organization/OrganizationApplicationTest.java  1
- department-client/src/test/java/com/rednavis/department/DepartmentApplicationTest.java  1
- employee-client/src/test/java/com/rednavis/employee/MongoDbContainer.java  1
- discovery-service/src/test/java/com/rednavis/discovery/DiscoveryApplicationTest.java  1
- zuul-service/src/test/java/com/rednavis/zuul/ZuulApplicationTest.java  1

See the complete overview on Codacy

AlexOreshkevich · 2020-03-03T12:30:12Z

README.md

-* http://localhost:8090/department/info
-* http://localhost:8090/organization/info
+### Swagger
+  - http://localhost:8090/swagger-ui.html


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:14Z

README.md

+```
+$ heroku addons:create mongolab:sandbox
+```
+  - Deploy code 


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:15Z

README.md

-* http://localhost:8090/department/info
-* http://localhost:8090/organization/info
+### Swagger
+  - http://localhost:8090/swagger-ui.html


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:16Z

README.md

+### Test microservice status
+  - http://localhost:8090/employeeEntity/info
+  - http://localhost:8090/department/info
+  - http://localhost:8090/organization/info


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:17Z

README.md

-* http://localhost:8090/swagger-ui.html
+## REST API exposed
+### Eureka
+  - http://localhost:8761/


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:18Z

README.md

-* http://localhost:8090/department/graphiql
-
-Test query:
+  - http://localhost:8090/department/graphiql


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:19Z

README.md

-* http://localhost:8090/department/graphiql
-
-Test query:
+  - http://localhost:8090/department/graphiql


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:20Z

README.md

+```
+$ heroku apps:create
+```
+  - Add a MongoDB database to your Heroku application with MongoLab. Note that your Heroku account must have a credit card attached in order to use free add-ons other than the PostgreSQL and MySQL add-ons.


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:21Z

README.md

+```
+$ heroku login
+```
+  - Create a new application on Heroku


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:22Z

README.md

+```
+$ git push heroku master
+```
+  - Look at your application logs to see what is happening behind the scenes.


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:23Z

README.md

-* http://localhost:8090/mock
+### Test microservice status
+  - http://localhost:8090/employeeEntity/info
+  - http://localhost:8090/department/info


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:24Z

README.md

-## GraphiQL
-* http://localhost:8090/employee/graphiql
+### Generate mock data
+  - http://localhost:8090/mock


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:25Z

README.md

-1. `./gradlew clean bootJar jibDockerBuild`
-2. `docker-compose up` 
+## Prerequisites
+  - OpenJDK 12.0.2 or higher


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:26Z

README.md


-Test query:
+### GraphiQL
+  - http://localhost:8090/employee/graphiql


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:27Z

README.md

-* http://localhost:8090/swagger-ui.html
+## REST API exposed
+### Eureka
+  - http://localhost:8761/


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:28Z

README.md

-## GraphiQL
-* http://localhost:8090/employee/graphiql
+### Generate mock data
+  - http://localhost:8090/mock


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:29Z

README.md

-* http://localhost:8090/organization/graphiql
-
-Test query:
+  - http://localhost:8090/organization/graphiql


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:30Z

README.md

+```
+$ heroku logs
+```
+  - If your application deploys without timing out then open it as follows.


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:32Z

README.md

-## Generate mock data
-* http://localhost:8090/mock
+### Test microservice status
+  - http://localhost:8090/employeeEntity/info


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:33Z

README.md

-* http://localhost:8090/organization/graphiql
-
-Test query:
+  - http://localhost:8090/organization/graphiql


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:34Z

README.md

-* http://localhost:8090/mock
+### Test microservice status
+  - http://localhost:8090/employeeEntity/info
+  - http://localhost:8090/department/info


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:35Z

README.md

+### Test microservice status
+  - http://localhost:8090/employeeEntity/info
+  - http://localhost:8090/department/info
+  - http://localhost:8090/organization/info


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:36Z

README.md

+```
+
+## Heroku setup
+  - Login to your heroku account from CLI


Issue found: [list-item-bullet-indent] Incorrect indentation before bullet: remove 2 spaces

AlexOreshkevich · 2020-03-03T12:30:37Z

README.md


-Test query:
+### GraphiQL
+  - http://localhost:8090/employee/graphiql


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

AlexOreshkevich · 2020-03-03T12:30:39Z

README.md

-## Generate mock data
-* http://localhost:8090/mock
+### Test microservice status
+  - http://localhost:8090/employeeEntity/info


Issue found: [no-literal-urls] Don’t use literal URLs without angle brackets

alabotski added 3 commits February 17, 2020 09:46

Remove project chekstyle

9ab5e53

Upgrade JDK to 12

b7b59d7

Add support travis and codecov

e88cc39

alabotski requested review from LeYaR, AlexOreshkevich and ashalak February 17, 2020 07:52

AlexOreshkevich requested changes Feb 17, 2020

View reviewed changes

alabotski added 3 commits February 18, 2020 11:28

Add support Heroku and change travis

d38ae04

Update travis

f5d5442

Refactor Employee test. Update jacoco

7679b8a

alabotski added 3 commits February 18, 2020 15:36

Merge remote-tracking branch 'origin/master' into improvements

e88dc10

# Conflicts: # README.md

Fix warnings

ecc784a

Fix README.md

cff3140

AlexOreshkevich requested review from AlexOreshkevich and removed request for ashalak March 3, 2020 12:26

AlexOreshkevich approved these changes Mar 3, 2020

View reviewed changes

AlexOreshkevich reviewed Mar 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements #4

Improvements #4

alabotski commented Feb 17, 2020

ghost commented Feb 17, 2020 •

edited by ghost

Loading

AlexOreshkevich left a comment

AlexOreshkevich commented Feb 17, 2020

alabotski commented Feb 17, 2020

alabotski commented Feb 17, 2020

codecov bot commented Feb 18, 2020 •

edited

Loading

AlexOreshkevich left a comment

AlexOreshkevich commented Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

AlexOreshkevich Mar 3, 2020

Improvements #4

Are you sure you want to change the base?

Improvements #4

Conversation

alabotski commented Feb 17, 2020

ghost commented Feb 17, 2020 • edited by ghost Loading

AlexOreshkevich left a comment

Choose a reason for hiding this comment

AlexOreshkevich commented Feb 17, 2020

alabotski commented Feb 17, 2020

alabotski commented Feb 17, 2020

codecov bot commented Feb 18, 2020 • edited Loading

Codecov Report

AlexOreshkevich left a comment

Choose a reason for hiding this comment

AlexOreshkevich commented Mar 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Feb 17, 2020 •

edited by ghost

Loading

codecov bot commented Feb 18, 2020 •

edited

Loading