USB Gecko: give up after 5s timeout #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ary
reviewed
Nov 2, 2023
9ary
reviewed
Nov 2, 2023
9ary
approved these changes
Nov 2, 2023
webhdx
force-pushed
the
usbgecko_timeout
branch
from
6682c65
to
d8b043b
Compare
|
Oh yeah I definitely had a brain fart when I was writing that title lol Fixed in d8b043b |
webhdx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one of the most annoying things in iplboot. When you have USB Gecko connected it will wait indefinitely for PC to accept data. This was problematic is all you wanted is to boot Swiss from SD card and use USB Gecko with Swiss. Now imagine testing 20 USB Geckos having to deal with this behavior :P
This PR adds 5s window to send data to USB Gecko. I think this is enough time because most likely you already have usb-load waiting for connection when you start iplboot.