Add cut command #45

hgrecco · 2016-03-25T17:58:54Z

All options are implemented except for -n

All options are implemented except for `-n`

hgrecco · 2016-03-25T18:01:10Z

As mentioned in the PR all options are implemented except for -n.

Additionally, I had to copy extra::io::fail because it was not compiling. Not a big deal, should be easy to replace once that is fixed upstream.

Tests are also included.

ticki · 2016-03-25T19:05:23Z

Additionally, I had to copy extra::io::fail because it was not compiling. Not a big deal, should be easy to replace once that is fixed upstream.

It compiles now. Just update your rustc.

ticki · 2016-03-25T19:05:32Z

src/bin/cut.rs

+
+// libextra is not compiling.
+use std::process;
+pub fn fail<'a>(s: &'a str, stderr: &mut io::Stderr) -> ! {


ticki · 2016-03-25T19:24:20Z

Very good code indeed. I left a bunch of comments.

hgrecco · 2016-03-26T02:08:30Z

Thanks a lot for your comments. I fixed all of them except when noted.

ticki · 2016-03-26T14:38:01Z

LFTM!

Add cut command

1ea75a8

All options are implemented except for `-n`

ticki reviewed Mar 25, 2016
View reviewed changes

Improved code based on review

d48acd3

ticki merged commit 0aae66b into redox-os:master Mar 26, 2016

Provide feedback