Early Beta of the Intel HD Audio Driver #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le-jzr
reviewed
Jun 10, 2017
| return Err("Could not map physical memory for buffer."); | ||
| } else { | ||
| unsafe {syscall::physfree(phys_addr, length);} | ||
| } |
There was a problem hiding this comment.
You return without freeing on error, and free pages when you succeed?
I'm not sure about the semantics of physmap and physfree, but this seems like a bug.
le-jzr
reviewed
Jun 10, 2017
| } | ||
|
|
||
| pub fn widget_type(&self) -> HDAWidgetType { | ||
| unsafe { mem::transmute( ((self.capabilities >> 20) & 0xF) as u8 )} |
There was a problem hiding this comment.
self.capabilities comes from hardware, right? Buggy device may cause undefined behavior here by providing invalid value.
|
Thanks for the catch! I have fixed the memory issue and the capabilities will be patched according to the codes that I test on. Good catch and thanks for looking through it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.