Add WIP calc. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,418 @@ | |||
| use std::prelude::v1::*; | |||
|
Cool stuff! I just added a few nit-picky comments. |
|
Ticki is asleep, so hoping that the issues were taken care of, I will merge. Thanks! |
|
Thanks! Functionality-wise it should be fine. Exponentiation is commented out until |
| let mut stderr = io::stderr(); | ||
| if args.len() > 1 { | ||
| let input: Vec<String> = args.skip(1).collect(); | ||
| println!("{}", eval(&input.join(""))); |
|
Great work, @LazyOxen! |
| let input_length = chars.len(); | ||
| let mut current_pos = 0; | ||
| while current_pos < input_length { | ||
| let c : char = chars[current_pos]; |
There was a problem hiding this comment.
No need for denoting the type here.
| match tokenize(input).and_then(parse) { | ||
| Ok(s) => s, | ||
| Err(e) => match e { | ||
| ParseError::InvalidNumber(s) => ["Invalid number: ", s.as_str() ].join(""), |
There was a problem hiding this comment.
concat() is slightly faster than join("").
|
Just read the code. It is extremely well-written and very readable. 👍 |
|
Thanks, been having some internet issues lately, hopefully I'll have better luck this weekend so I can update the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a few TODOs. The main ones would be converting the functions to use iterators if possible, as well as getting exponentiation to work, the compiler kept barking at me regarding
powf, and I wasn't sure how to fix it.