New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly parse statements with multiple escaped characters #292

Merged

mmstick merged 2 commits into redox-os:master from hgoldstein:master

Jun 6, 2017

Contributor

hgoldstein commented Jun 6, 2017

Problem: Statements such as foo\(\) were not being correctly parsed, see #291.

Solution: Whenever a character is read by a WordIterator when the BACKSL flag is set, the flag gets unset.

Changes introduced by this pull request:

Backslash flag now reset upon reading the escaped character
Add regression test for multiple backslashes

Drawbacks:

It could use some more tests for these sorts of use cases
It is unclear if this affects the other uses of the WordIterator beyond parsing command line statements.

Fixes: Resolves #291.
State: Ready with the caveat of adding more unit / regression tests, also formatting and such.

hgoldstein added 2 commits

June 6, 2017 18:29


          Backslash flag now reset upon reading the escaped character

636af2b


          Add regression test for multiple backslashes

2ea6cea

mmstick merged commit 1ecae0a into redox-os:master

Contributor

mmstick commented Jun 6, 2017

Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment