Hide Tokio crates behind cfg gate for Redox #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Can you also change |
jackpot51
reviewed
Jun 20, 2017
| @@ -27,6 +27,8 @@ permutate = "0.3" | |||
| unicode-segmentation = "1.2" | |||
| smallvec = "0.4" | |||
| smallstring = "0.1" | |||
|
|
|||
| [target.'cfg(not(target_os = "redox"))'.dependencies] | |||
There was a problem hiding this comment.
Should this also contain futures ?
There was a problem hiding this comment.
It should and it does now.
|
Thanks! This should work for handling Redox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314.
I'm still trying to set up a redox environment (see: https://github.com/redox-os/redox/issues/970; I'm giving up trying to do this locally for now, spinning up Ubuntu VM) but in the meantime this should work.