-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement &|
stdout and stderr piping
#368
Merged
mmstick
merged 17 commits into
redox-os:master
from
hgoldstein:stdout_and_stderr_redirect
Jul 7, 2017
Merged
Implement &|
stdout and stderr piping
#368
mmstick
merged 17 commits into
redox-os:master
from
hgoldstein:stdout_and_stderr_redirect
Jul 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the work! I'm about to land some big changes myself to the pipe logic -- process groups, signal masking, foreground management. Albeit, I've yet to figure out why my |
And merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this pull request:
&|
is now part of the grammar as the stdout and stderr piping operator&|
is now supported on *nix and RedoxDrawbacks:
crossplat
module is a little messy. Perhaps moving all of the platform specific code to a separate file altogether would be better. It seems like Rust's pattern for this is something like:Fixes: Closes #331
State: Ready to go, pending review.