Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore SIGTTOU before setting process group #462

Merged
merged 3 commits into from Jul 24, 2017
Merged

Ignore SIGTTOU before setting process group #462

merged 3 commits into from Jul 24, 2017

Conversation

hgoldstein
Copy link
Contributor

Fixes: Closes #461

Other: This should work on Redox but I cannot confirm; having trouble testing on Redox as the build is currently broken.

@mmstick
Copy link
Contributor

mmstick commented Jul 24, 2017

May be better to call signals::block(), which also ensures that SIGTTOU is blocked.

@hgoldstein
Copy link
Contributor Author

Also, I finally don't see #369 happening! I get the feeling it was some strange race condition.

@mmstick
Copy link
Contributor

mmstick commented Jul 24, 2017

Thanks!

@mmstick mmstick merged commit 2875463 into redox-os:master Jul 24, 2017
@hgoldstein hgoldstein deleted the signals_dude branch July 24, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hgoldstein @mmstick