New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow builtins to be executed as part of pipelines #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `unimplemented!()` stubs where logic for actually running builtins - fun with the borrow checker!
Also it seems I forgot to add |
Looks good to me so far. |
Good to go; I wanted to add an example for EDIT: See #474 |
Thanks for this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Currently if we have a builtin to be run as part of a pipeline, we just take the job, reconstruct it, and run a sub-process such as
ion -c builtin arg1 arg2
. This is problematic as it forcesion
to re-parse the given arguments which is inefficient and bug prone ( #454 ).Solution: Manually manage running builtins as part of a pipeline by forking the current process and executing the builtin in the child process.
Changes introduced by this pull request:
Command
inshell::pipe
withRefinedJob
; an enumeration that is either an external command or a builtinshell::pipe::pipe
to fork and execute a builtin for theRefinedJob::Builtin
instance; behavior forRefinedJob::External
is roughly the same as before: build aCommand
, runspawn()
.Drawbacks: The use of
RawFd
everywhere might make #364 more difficult.Fixes: Closes #379 ; Closes #454
State: WIP; I want to make sure there are some regression tests in
examples/
. Also this is a 500+- change so letting it sit for review would be good.TODO:
STDOUT_FILENO
et alexamples/
for piping to / from a builtin #