Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RawFDs now managed by forked process, not shell::pipe::builtin, when appropriate #479

Merged
merged 1 commit into from Jul 27, 2017
Merged

Conversation

hgoldstein
Copy link
Contributor

Changes introduced by this pull request:

  • shell::pipe::builtin will not close any file descriptors: this will be done by RefinedJob::drop or inside the child process if appropriate. This prevents a double close in the case of a builtin being run in the parent process.

Fixes: Closes #478


@mmstick: I'm thinking about replacing all of the RawFds with Files. It would mean that RefinedJob doesn't need to have a custom Drop implementation and it means we are less dependent on *nix specific things. Thoughts?

@mmstick
Copy link
Contributor

mmstick commented Jul 27, 2017

@huntergoldstein If we can do it that way, then that would be good.

@mmstick mmstick merged commit ad6d363 into redox-os:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants