RawFDs now managed by forked process, not shell::pipe::builtin, when appropriate #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this pull request:
shell::pipe::builtin
will not close any file descriptors: this will be done byRefinedJob::drop
or inside the child process if appropriate. This prevents a double close in the case of a builtin being run in the parent process.Fixes: Closes #478
@mmstick: I'm thinking about replacing all of the
RawFd
s withFile
s. It would mean thatRefinedJob
doesn't need to have a customDrop
implementation and it means we are less dependent on *nix specific things. Thoughts?