writeln!(stderr, ...) -> eprintln! #644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in other tasks, I noticed that there's a rather
inconsistent way to handle errors. In some places we use
eprintln!
andin others
writeln!
to standard error.It seems like the use of
writeln!
don't have an strong motive, as theoutput is always to standard error, the lock is always handled the same
than
eprintln
and there's no obvious (to me) optimization, so Idecided to use the more idiomatic
eprintln!
everywhere.Let me know if there's seomthing I'm missing!