support for FileManager in List and Window #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyeTbk
reviewed
Mar 6, 2017
src/widgets/list.rs
Outdated
| // drawn at that point. | ||
| fn get_entry(&self, p: Point) -> Option<Arc<Entry>> { | ||
| fn get_entry_index(&self, p: Point) -> i32 { |
There was a problem hiding this comment.
This function should probably return an Option<usize> or Option<u32> instead of an i32. Using None instead of -1 to indicate that there is no entry at the given point would be more idiomatic rust, I believe.
|
List selection uses |
| pub running: Cell<bool> | ||
| pub bg: Cell<Color>, | ||
| pub running: Cell<bool>, | ||
| events: Vec<Event>, |
There was a problem hiding this comment.
I'd favor internal mutability (RefCell<Vec<Event>>) over requiring windows to be changed to mutable.
There was a problem hiding this comment.
Ideally I'd like to get rid of mutability and internal mutability entirely, by moving towards what I describe in the PR description.
|
Sorry I did not get around to this earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listselectedentry, which will be highlightedScrollEventhome/endto jump to top and bottomentersimulates a click on the entryWindowThis PR breaks
execup into a few pieces that can be called independently. This allows FileManager to still maintain its own event queue. In the future I'd like to put everything back behindexec, but not at the window level.Instead I think it would be nice to have an
Applicationwhich is capable of housing multipleWindows and accepts some sort of callback that allows the application to hook into the application loop. Which would allow behavior like in this FileManager PR (redox-os/orbutils#19), but without the app having to poke atWindowin very specific ways.