Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import of std::ascii::AsciiExt #142

Merged
merged 1 commit into from May 9, 2018

Conversation

d-e-s-o
Copy link
Contributor

@d-e-s-o d-e-s-o commented Apr 20, 2018

The import of std::ascii::AsciiExt in src/event.rs is unused. Remove it.

warning: unused import: std::ascii::AsciiExt
--> src/event.rs:4:5
|
4 | use std::ascii::AsciiExt;
| ^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

The import of std::ascii::AsciiExt in src/event.rs is unused. Remove it.

> warning: unused import: `std::ascii::AsciiExt`
>  --> src/event.rs:4:5
>   |
> 4 | use std::ascii::AsciiExt;
>   |     ^^^^^^^^^^^^^^^^^^^^
>   |
>   = note: #[warn(unused_imports)] on by default
@JoshMcguigan JoshMcguigan merged commit b9881e1 into redox-os:master May 9, 2018
@knarfytrebil
Copy link

Hello, it turns out if remove use std::ascii::AsciiExt;
some of the examples will not be able to compile.

   Compiling termion v1.5.1 (file:///Users/knarfytrebil/Programs/rust/termion)
error[E0599]: no method named `is_ascii` found for type `u8` in the current scope
   --> src/event.rs:317:10
    |
317 |     if c.is_ascii() {
    |          ^^^^^^^^
    |
    = help: items from traits can only be used if the trait is in scope
    = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
            candidate #1: `use std::ascii::AsciiExt;`

error: aborting due to previous error

error: Could not compile `termion`.

To learn more, run the command again with --verbose.

@JoshMcguigan
Copy link
Contributor

Which examples are you not able to compile?

@d-e-s-o d-e-s-o deleted the remove-unused-import branch May 11, 2018 00:52
@knarfytrebil
Copy link

Sorry, I was on an older version of rust.
It resolved after I upgraded rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants