Revisited login.
#10
Merged
Revisited login.
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goyox86
force-pushed
the
goyox86/login-improvements
branch
from
d9d828f
to
d3616d2
Compare
- Added constants for standard file paths. - Improved error reporting when opening the files. - Used `Passwd::parse_file` instead of doing it manually. - Removed all the calls to unwrap(). - Used `fail` to report errors and exit when possible.
goyox86
force-pushed
the
goyox86/login-improvements
branch
from
d3616d2
to
1aa558e
Compare
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passwd::parse_fileinstead of doing it manually.try().failto report errors and exit when possible.