Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all occurrences of Redis port number, using 6379. #2572

Closed
wants to merge 5 commits into from
Closed

Fix all occurrences of Redis port number, using 6379. #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d3f3b7
Update rpk run command
Jeffail May 30, 2024
c85743e
Update docker commands in README
Jeffail May 30, 2024
b4a340d
Fix links in release notes script
Jeffail May 31, 2024
92f3f91
Fix all occurrences of Redis port number, using 6379.
olgeni Jun 2, 2024
5150c23
Merge branch 'redpanda-data:main' into redis-port-fix
olgeni Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/modules/components/pages/caches/redis.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Common::
# Common config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
prefix: "" # No default (optional)
```

Expand All @@ -40,7 +40,7 @@ Advanced::
# All config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -74,7 +74,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/inputs/redis_list.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
input:
label: ""
redis_list:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
key: "" # No default (required)
auto_replay_nacks: true
```
Expand All @@ -44,7 +44,7 @@ Advanced::
input:
label: ""
redis_list:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -77,7 +77,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/inputs/redis_pubsub.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
input:
label: ""
redis_pubsub:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
channels: [] # No default (required)
use_patterns: false
auto_replay_nacks: true
Expand All @@ -45,7 +45,7 @@ Advanced::
input:
label: ""
redis_pubsub:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -84,7 +84,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/inputs/redis_scan.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Common::
input:
label: ""
redis_scan:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
auto_replay_nacks: true
match: ""
```
Expand All @@ -46,7 +46,7 @@ Advanced::
input:
label: ""
redis_scan:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -87,7 +87,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/inputs/redis_streams.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
input:
label: ""
redis_streams:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
body_key: body
streams: [] # No default (required)
auto_replay_nacks: true
Expand All @@ -48,7 +48,7 @@ Advanced::
input:
label: ""
redis_streams:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -88,7 +88,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/outputs/redis_hash.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
output:
label: ""
redis_hash:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
key: ${! @.kafka_key )} # No default (required)
walk_metadata: false
walk_json_object: false
Expand All @@ -47,7 +47,7 @@ Advanced::
output:
label: ""
redis_hash:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -111,7 +111,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/outputs/redis_list.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
output:
label: ""
redis_list:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
key: some_list # No default (required)
max_in_flight: 64
batching:
Expand All @@ -49,7 +49,7 @@ Advanced::
output:
label: ""
redis_list:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -94,7 +94,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/outputs/redis_pubsub.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
output:
label: ""
redis_pubsub:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
channel: "" # No default (required)
max_in_flight: 64
batching:
Expand All @@ -49,7 +49,7 @@ Advanced::
output:
label: ""
redis_pubsub:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -93,7 +93,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/outputs/redis_streams.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
output:
label: ""
redis_streams:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
stream: "" # No default (required)
body_key: body
max_length: 0
Expand All @@ -53,7 +53,7 @@ Advanced::
output:
label: ""
redis_streams:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -103,7 +103,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/processors/redis.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
# Common config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
command: scard # No default (optional)
args_mapping: root = [ this.key ] # No default (optional)
```
Expand All @@ -43,7 +43,7 @@ Advanced::
# All config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -137,7 +137,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/processors/redis_script.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Common::
# Common config fields, showing default values
label: ""
redis_script:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
script: return redis.call('set', KEYS[1], ARGV[1]) # No default (required)
args_mapping: root = [ this.key ] # No default (required)
keys_mapping: root = [ this.key ] # No default (required)
Expand All @@ -45,7 +45,7 @@ Advanced::
# All config fields, showing default values
label: ""
redis_script:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -114,7 +114,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/components/pages/rate_limits/redis.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Common::
# Common config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
count: 1000
interval: 1s
key: "" # No default (required)
Expand All @@ -44,7 +44,7 @@ Advanced::
# All config fields, showing default values
label: ""
redis:
url: redis://:6397 # No default (required)
url: redis://:6379 # No default (required)
kind: simple
master: ""
tls:
Expand Down Expand Up @@ -75,7 +75,7 @@ The URL of the target Redis server. Database is optional and is supplied as the
```yml
# Examples

url: redis://:6397
url: redis://:6379

url: redis://localhost:6379

Expand Down
2 changes: 1 addition & 1 deletion internal/impl/redis/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Some cloud hosted instances of Redis (such as Azure Cache) might need some hand
return []*service.ConfigField{
service.NewURLField("url").
Description("The URL of the target Redis server. Database is optional and is supplied as the URL path.").
Example("redis://:6397").
Example("redis://:6379").
Example("redis://localhost:6379").
Example("redis://foousername:foopassword@redisplace:6379").
Example("redis://:foopassword@redisplace:6379").
Expand Down