Add Splunk TLS fields #2666
Merged
Add Splunk TLS fields #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1905. Signed-off-by: Mihai Todor <todormihai@gmail.com>
Jeffail
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1905.
I also cleaned some leftover typos... I was overly-excited when I finally figured out how to use that Splunk container and forgot to re-read my code :)
To test this, I couldn't figure out how to fetch the cert used by the container for those endpoints, so I ended up running https://mitmproxy.org as a local HTTP reverse proxy and I set
tls.root_cas_file: ${HOME}/.mitmproxy/mitmproxy-ca-cert.pem.