Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to load large messages, ignoring size limit #1129

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Ability to load large messages, ignoring size limit #1129

merged 8 commits into from
Feb 29, 2024

Conversation

rikimaru0345
Copy link
Contributor

@rikimaru0345 rikimaru0345 commented Feb 22, 2024 •
edited

This solves #1059

This PR is not done yet.
Missing:

  • fixing the naming of properties in the MessageSearch type
  • disable button/loading spinner when loading is in progress
  • proper error messages reporting (in the ui) when something fails
  • add ui tests

@rikimaru0345 rikimaru0345 mentioned this pull request Feb 22, 2024
Merged
@rikimaru0345
Copy link
Contributor Author

chrome_6oCnO1P1DW.mp4

@rikimaru0345 rikimaru0345 marked this pull request as ready for review February 29, 2024 15:14
@rikimaru0345 rikimaru0345 merged commit 1ab6610 into master Feb 29, 2024
5 of 6 checks passed
@rikimaru0345 rikimaru0345 deleted the download-large-msg branch February 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvorcak jvorcak jvorcak approved these changes

@weeco weeco Awaiting requested review from weeco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rikimaru0345 @jvorcak