frontend: Move to vite for build, runtime, tests #939
+23,080
−41,872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malinskibeniamin
requested review from
frankieshakes,
jvorcak,
sago2k8 and
rikimaru0345
|
|
frontend/package.json
Outdated
| "serve": "vite preview --port 3004", | ||
| "test": "TZ=GMT jest --coverage --watchAll=false", | ||
| "test:dev": "TZ=GMT jest --coverage --watchAll", | ||
| "test-interpreter-code": "ts-node --project src/utils/interpreter/tsconfig.json src/utils/interpreter/findFunction.test.ts", |
frontend/package.json
Outdated
Comment on lines
39
to
40
| "eslint": "^8.3.0", | ||
| "eslint-config-react-app": "^7.0.1", |
frontend/package.json
Outdated
| "antd": "^4.21", | ||
| "array-move": "^4", | ||
| "camelcase": "^6.2.1", | ||
| "dotenv": "^10.0.0", |
frontend/package.json
Outdated
| "jest-resolve": "^29.7.0", | ||
| "jest-watch-typeahead": "^2.2.2", | ||
| "node-fetch": "^3.3.0", | ||
| "sass": "^1.58.3", |
There was a problem hiding this comment.
maybe remove?
frontend/package.json
Outdated
| "typescript": "^4.9.5" | ||
| }, | ||
| "resolutions": { | ||
| "//": "See https://github.com/facebook/create-react-app/issues/11773", |
There was a problem hiding this comment.
check if works after removing
| @@ -1,5 +1,6 @@ | |||
| import { Select as RPSelect } from '@redpanda-data/ui'; | |||
| import { SelectProps as RPSelectProps, isSingleSelectOptions, isSingleValue } from '@redpanda-data/ui/dist/components/Inputs/Select/Select'; | |||
| import { isSingleSelectOptions, isSingleValue } from '@redpanda-data/ui'; | |||
| import { SelectProps as RPSelectProps } from '@redpanda-data/ui/dist/components/Inputs/Select/Select' | |||
There was a problem hiding this comment.
Let's export SelectProps via UI library, or any props of any component for that matter.
Thanks to @frankieshakes and @rikimaru0345 for the heads up.
| @@ -2,12 +2,13 @@ | |||
| "compilerOptions": { | |||
| "experimentalDecorators": true, | |||
| "useDefineForClassFields": true, | |||
| "target": "es2019", | |||
There was a problem hiding this comment.
| react({ // Needed to keep using MobX with legacy decorator patterns enabled | ||
| babel: { | ||
| parserOpts: { | ||
| plugins: ['decorators-legacy', 'classProperties'] |
There was a problem hiding this comment.
1 day we could get rid of decorators
malinskibeniamin
force-pushed
the
vite
branch
from
3f48c9d
to
f43103e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP