Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve liveness probe to use builtin http probe instead of curl #1278

Open
hcoyote opened this issue May 13, 2024 · 0 comments
Open

Improve liveness probe to use builtin http probe instead of curl #1278

hcoyote opened this issue May 13, 2024 · 0 comments

Comments

@hcoyote
Copy link

hcoyote commented May 13, 2024

What would you like to be added?

Update the liveness probe to utilize the builtin-in http check rather than a curl.

https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-http-request

          # the livenessProbe just checks to see that the admin api is listening and returning 200s.
          livenessProbe:
            exec:
              command:
                - /bin/sh
                - -c
                - curl --silent --fail -k  "http://${SERVICE_NAME}.redpanda-cluster.prod.svc.cluster.local.:9644/v1/status/ready"
            initialDelaySeconds: 10
            failureThreshold: 3
            periodSeconds: 10

See additional details in slack thread: https://redpandadata.slack.com/archives/C01H6JRQX1S/p1715624674945489

Why is this needed?

This would avoid a slow exec out to curl and reduce the surface area of failure should a DNS resolution not work out per the way we currently do the liveness probe (k8s cluster DNS failure could cause cascading failure of the Redpanda cluster even though RP may be alive and healthy).

@hcoyote hcoyote changed the title Improve liveness probe to utilize to use builtin http probe instead of curl Improve liveness probe to use builtin http probe instead of curl May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant