avoid empty dnsNames if custom issuerRef is set #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reytech-dev
requested review from
RafalKorepta,
alejandroEsc and
chrisseto
as code owners
| @@ -23,7 +23,7 @@ type: application | |||
| # The chart version and the app version are not the same and will not track | |||
| # together. The chart version is a semver representation of changes to this | |||
| # chart. | |||
| version: 5.7.23 | |||
There was a problem hiding this comment.
I'm confused why patch version was bumped +2, but not +1?
| @@ -0,0 +1,26 @@ | |||
|
|
|||
There was a problem hiding this comment.
This file name should be charts/redpanda/ci/19-certs-dns-names-values.yaml, right?
Comment on lines
+19
to
+23
| certs: | ||
| default: | ||
| issuerRef: | ||
| name: custom-internal-issuer-ref | ||
| kind: ClusterIssuer |
There was a problem hiding this comment.
The test will always fail as CI doesn't creates external issuer. It would require injecting ClusterIssuer in to template folder. That will only test helm install, but upgrade test would not work at all (helm upgrade) as chart-testing downloads previous version from the upstream.
RafalKorepta
force-pushed
the
fix/empty-dns-names-certs
branch
from
a8af4e9
to
b58c416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after turning off the "external"-attribute in the redpanda chart, I ran into an issue because the certificate got created with no "dnsNames".
The proposed change always adds "dnsNames" to the certificates if no external domains are provided.
Please let me know if there are further changes required or anything is not right with my changes.
Regards