WIP: Proposal for new values shape #1191
Conversation
| @@ -62,3 +62,114 @@ func RedpandaAdditionalStartFlags(dot *helmette.Dot, smp, memory, reserveMemory | |||
|
|
|||
| return append(flags, values.Statefulset.AdditionalRedpandaCmdFlags...) | |||
| } | |||
|
|
|||
| // func RedpandaYAMLKafkaListeners(dot *helmette.Dot) []KafkaListener { | |||
There was a problem hiding this comment.
Was exploring the existing listener configurations. Will likely have a function that converts the existing shape into this structure and we'll convert our templates to use the new structure.
chrisseto
force-pushed
the
chris/kafka-listeners
branch
from
d02bfc3
to
b71d0fe
Compare
| @@ -1,12 +1,15 @@ | |||
| //+gotohelm:ignore=true | |||
| // +gotohelm:ignore=true | |||
There was a problem hiding this comment.
NIT: I wonder why my IDE is changing this every time 🤔
There was a problem hiding this comment.
This is actually due to go fmt. We don't run it against the entire codebase right now and this annotation is technically incorrect 😓 . Filed an issue #1194
| // KeyFile maps to the `kafka_api_tls[*].key_file` field. | ||
| KeyFile FileSource | ||
|
|
||
| // CertFile maps to the `kafka_api_tls[*].cert_file` field. | ||
| CertFile FileSource | ||
|
|
||
| // TrustStoreFile maps to the `kafka_api_tls[*].truststore_file` field. | ||
| // +kubebuilder:default={"path": "/etc/ssl/certs/ca-certificates.crt"} | ||
| TrustStoreFile *FileSource |
There was a problem hiding this comment.
I wonder how users would control volume mount points.
There was a problem hiding this comment.
I like this approach. One requirement from me, that would defiantly land in core team backlog, is node configuration schema. I see potential problems with Redpanda core having fields deprecation that affects our code. That breaking change never happen (as far as I remember), so I would vote for this change/approach 👍
chrisseto
force-pushed
the
chris/kafka-listeners
branch
from
b71d0fe
to
98f4525
Compare
Early working draft of my proposal on where we should move with our Values struct. Currently focused on redpanda.yaml and providing an "advanced mode" type of experience.
This PR is for discussion and will likely be splintered across many PRs once there's a general consensus.
Various notes:
---divider.