gotohelm: Refactor test template executor #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, gotohelm ran "helm" tests via an inline template runner. This muddled what code was performing test assertions and what code was attempting to execute the transpiled templates in a helm-like fashion. This commit extracts the template execution out into it a runner struct similar to the go runner struct. In the future, we may want to provide direct access to the go runner and helm runner structs to allow transpiled charts to easily test either the gocode path and helm path.
RafalKorepta
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gotohelm ran "helm" tests via an inline template runner. This muddled what code was performing test assertions and what code was attempting to execute the transpiled templates in a helm-like fashion.
This commit extracts the template execution out into it a runner struct similar to the go runner struct. In the future, we may want to provide direct access to the go runner and helm runner structs to allow transpiled charts to easily test either the gocode path and helm path.