redpanda: values.statefulSet.initContainers.tuning.extraVolumeMounts … #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-g
requested review from
JakeSCahill,
RafalKorepta and
chrisseto
as code owners
chrisseto
approved these changes
Jul 3, 2024
RafalKorepta
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
The TestConfigMap unit test should be removed.
2024-07-03T14:15:00.7872707Z >>> helm upgrade redpanda-zip5cxmbin charts/redpanda --namespace redpanda-zip5cxmbin --wait --values ct_previous_revision2253065169/charts/redpanda/ci/09-initcontainers-resources-values.yaml --timeout 600s --set=image.tag=
2024-07-03T14:15:00.8810463Z Error: UPGRADE FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
2024-07-03T14:15:00.8816279Z redpanda:
2024-07-03T14:15:00.8817525Z - statefulset.initContainers.tuning.extraVolumeMounts: Invalid type. Expected: array, given: string
There was few errors that was not your fault:
Failed to pull image "docker.redpanda.com/redpandadata/redpanda:v23.1.21": failed to pull and unpack image "docker.redpanda.com/redpandadata/redpanda:v23.1.21": failed to copy: httpReadSeeker: failed open: unexpected status code https://docker.redpanda.com/v2/redpandadata/redpanda/manifests/sha256:d4fbc2abff8cda929b5c3328fcfb494720796bf8caa8a22ae0eac7fea807a11c: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Over all LGTM
jan-g
force-pushed
the
gotohelm-init-containers
branch
from
23dcc88
to
38c867b
Compare
…is now an array, not a string template This begins a conversion of statefulset.yaml init-containers to go. As a part of this, the `values.yaml` type for `extraVolumeMounts` is refined to take an explicit `corev1.VolumeMount` structure rather than a bare string that was interpreted as templated yaml.
jan-g
force-pushed
the
gotohelm-init-containers
branch
from
38c867b
to
38f495d
Compare
|
I'm closing this in favour of #1408 which has all these changes collapsed into a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is now an array, not a string template
This begins a conversion of statefulset.yaml init-containers to go.
As a part of this, the
values.yamltype forextraVolumeMountsis refined to take an explicitcorev1.VolumeMountstructure rather than a bare string that was interpreted as templated yaml.