Fix any Node configuration that is of numerical type #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example crash_loop_limit can change value type from integer to string while template engine converts it due to `toYaml` function usage. Reference https://docs.redpanda.com/current/reference/properties/broker-properties/#crash_loop_limit
chrisseto
approved these changes
Jul 3, 2024
Maybe Redpanda is not strict about it. Redpanda apparently could work with string conversion to integer (I verified that manually). I found out by yaml.Unmarshall using RPK go struct that represent Redpanda Node Configuration. |
As migration to go based Redpanda configuration is done, any further differences should not be handled in test case.
RafalKorepta
force-pushed
the
rk/fix-crash-loop-limit
branch
from
ec786d9
to
7dfcdea
Compare
|
oooooooh, fascinating. I remember stumbling across the C++ YAML parsing and noting how different it was. Seems like it's more permissive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example crash_loop_limit can change value type from integer to string while template engine converts it due to
toYamlfunction usage.Reference
https://docs.redpanda.com/current/reference/properties/broker-properties/#crash_loop_limit