feat: servicemonitor additional labels. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tower-nyc
requested review from
joejulian,
RafalKorepta and
alejandroEsc
as code owners
joejulian
approved these changes
May 23, 2023
|
@tower-nyc could you please bump the chart version in this PR. Thank you. |
RafalKorepta
force-pushed
the
servicemonitor-labels
branch
2 times, most recently
from
844f082
to
bb50f70
Compare
Change-Id: I53976b4efcc89544afb541f2c3f9ea173ac1cac7
RafalKorepta
force-pushed
the
servicemonitor-labels
branch
from
f291631
to
99db437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I53976b4efcc89544afb541f2c3f9ea173ac1cac7
Prometheus / VictoriaMetrics typically uses labels to discriminate scrapping instance.