Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: rpk cluster config set needs full list of brokers #522

Merged
merged 2 commits into from
May 26, 2023
Merged

FIX: rpk cluster config set needs full list of brokers #522

merged 2 commits into from
May 26, 2023

Conversation

alejandroEsc
Copy link
Contributor

No description provided.

@alejandroEsc alejandroEsc self-assigned this May 26, 2023
RafalKorepta
RafalKorepta approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a follow up I will remove rpk acl user flags that is redundant.

@RafalKorepta RafalKorepta changed the title FIX: sasl rpk command changed, needs environment var to work again. FIX: rpk cluster config set needs full list of brokers May 26, 2023
@RafalKorepta RafalKorepta added this pull request to the merge queue May 26, 2023
Merged via the queue into main with commit 80492a3 May 26, 2023
11 of 13 checks passed
@RafalKorepta RafalKorepta deleted the ae/sasl/fix branch May 26, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalKorepta RafalKorepta RafalKorepta approved these changes

@joejulian joejulian Awaiting requested review from joejulian

Assignees

@alejandroEsc alejandroEsc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alejandroEsc @RafalKorepta