Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to check TLS state for dry-runs #534

Merged

Conversation

phooijenga
Copy link
Contributor

When running helm template or passing --dry-run, the built-in lookup function always returns an empty map. This results in the check thinking that TLS is currently not enabled for RPCs, generating an error.

To reproduce:

$ helm install redpanda redpanda/redpanda
...
$ helm upgrade redpanda redpanda/redpanda --dry-run
Error: UPGRADE FAILED: execution error at (redpanda/templates/statefulset.yaml:60:28): 

Error: Cannot do a rolling restart to enable or disable tls at the RPC layer: changing listeners.rpc.tls.enabled (redpanda.yaml:repdanda.rpc_server_tls.enabled) from false to true
***WARNING The following instructions will result in a short period of downtime.
To accept this risk, run the upgrade again adding `--set force=true` and do the following:

While helm is upgrading the release, manually delete ALL the pods:
    kubectl -n infra delete pod -l app.kubernetes.io/component=redpanda-statefulset

If you got here thinking rpc tls was already enabled, see technical service bulletin 2023-01.

$ helm upgrade redpanda redpanda/redpanda
Release "redpanda" has been upgraded. Happy Helming!
...

@CLAassistant
Copy link

CLAassistant commented May 31, 2023

CLA assistant check
All committers have signed the CLA.

@phooijenga phooijenga force-pushed the fix-tls-enabled-check-dry-run branch from 8c60cdc to 32817d9 Compare June 1, 2023 07:15
@phooijenga
Copy link
Contributor Author

I noticed the lint action failed because the branch did not include a version bump, so I rebased and added one.

@RafalKorepta RafalKorepta force-pushed the fix-tls-enabled-check-dry-run branch from 32817d9 to cb72a73 Compare June 1, 2023 10:36
@RafalKorepta RafalKorepta merged commit 43c6b32 into redpanda-data:main Jun 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants