-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shadow indexing #56
Conversation
09992b8
to
f518cfc
Compare
I'm unable to add reviewers so I'll ping a few people who I've talked with about this PR here: @bpraseed @redp01 @larsenpanda @rkruze . This PR looks big, but most of the updates relate to adding properties to the Values.yaml file. This was done so users of the chart will have a better idea of what is possible, and it may make it easier for this chart to be included in other upstream tools in the future. I received some feedback between when I first posted this and now, and I've incorporated that feedback already. |
I didn't include some properties that exist. Here are some of them below. I didn't see many other examples where these properties were used, but they could be added if anyone thinks it would be valuable.
|
This PR doesn't update to the latest Redpanda, instead it uses |
@vuldin - thinking that it might be a good idea to add a basic helm test for the shadow indexing example. I think it should be fairly quick to add as it can just follow the existing tests. |
1 similar comment
@vuldin - thinking that it might be a good idea to add a basic helm test for the shadow indexing example. I think it should be fairly quick to add as it can just follow the existing tests. |
Minor: Testing step by step according to the readme - I've noticed that the cert manager installation is using > to denote the next command line; however, its actually chained with the && operator so two of the > seem superfluous and prevent a straight copy paste of the command into bash. |
@vuldin - I ran through the shadow indexing script in the readme from beginning to end. I took the Kind pathway on Mac OS 11.6.5. All seems to work perfectly and the watch on the minio bucket is a nice touch. |
type: application | ||
version: 1.0.7 | ||
deprecated: true | ||
appVersion: 21.11.11 | ||
icon: https://redpanda.com/static/skate-panda-9c2e4bc5a1ed0052554e658519a50882.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this link be to another resource? I'm worried the SVG filename is generated by a release process (or something) and will no longer work at some point.
f518cfc
to
b161c8d
Compare
Looks like I caused an issue with the Redpanda config when handling merge conflicts with previously merged commits to main. I'll take a look soon and force another push. I'm surprised by this because I was checking locally with |
Switched this to draft. After discussing with @rkruze , I will split out the values.yaml modifications into a separate PR. This PR will be focused more on the shadow indexing changes, and will be again up for review once these changes are made. |
While creating this PR, it became evident there were many changes that were needed to this project before adding in a new feature. Most of these changes are found in #85 . Once PR 85 merged then a new (much smaller) shadow indexing PR will be created. |
Hello, is there any way to track progress on this - since #85 is merged for some time. |
This PR primarily enables shadow indexing configuration within the helm chart. But in the process the following changes are made:
This PR will move out of draft once the following tasks are complete:
_helpers.tpl
I hope to have both of the above tasks done by EOD Monday.
closes #41 , closes #52