Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SASL/OAUTHBEARER #223

Closed
bachmanity1 opened this issue Aug 31, 2023 · 4 comments
Closed

Add support for SASL/OAUTHBEARER #223

bachmanity1 opened this issue Aug 31, 2023 · 4 comments

Comments

@bachmanity1
Copy link
Contributor

kminion/kafka/config_sasl.go

Lines 40 to 41 in 2f841e3

case SASLMechanismOAuthBearer:
return fmt.Errorf("sasl mechanism '%v' is valid but not yet supported. Please submit an issue if you need it", c.Mechanism)

We've been using kminion to monitor consumer group lags and so far our experience has been great, but soon we are planning to make all our Kafka clusters use SASL/OAUTHBEARER and it looks like we won't be able to use kminion anymore.

Can you please add support for SASL/OAUTHBEARER? Thanks!
@bachmanity1
Copy link
Contributor Author

@weeco if you don't mind I can start working on this feature sometime soon.

@weeco
Copy link
Contributor

weeco commented Dec 1, 2023

@bachmanity1 Please go ahead. You can have a look at the Console repository where OAuthBearer is already supported.

@bachmanity1
Copy link
Contributor Author

@weeco I've opened PR #230

@bachmanity1
Copy link
Contributor Author

resolved by #230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weeco @bachmanity1