Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SASL/OAUTHBEARER #230

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

bachmanity1
Copy link
Contributor

@bachmanity1 bachmanity1 commented Dec 6, 2023

I tested this on a SASL/OAUTHBEARER-enabled cluster, and it works well.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@weeco weeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor change request. Thank you!

kafka/config_sasl.go Outdated Show resolved Hide resolved
@bachmanity1
Copy link
Contributor Author

@weeco Thanks for the review. I have addressed your comment.

@weeco
Copy link
Contributor

weeco commented Dec 6, 2023

@bachmanity1 One thing I missed in my review: Could we add OAUTHBEARER as a valid mechanism to the reference config on the mechanism field? Then it's good to merge I believe. Thank you again

@bachmanity1
Copy link
Contributor Author

@bachmanity1 One thing I missed in my review: Could we add OAUTHBEARER as a valid mechanism to the reference config on the mechanism field? Then it's good to merge I believe. Thank you again

Done.

@weeco weeco merged commit 4fa1a11 into redpanda-data:master Dec 6, 2023
1 check passed
@bachmanity1 bachmanity1 deleted the add-oauthbearer branch December 6, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants