-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm example improvements #12
Wasm example improvements #12
Conversation
This PR resolves an error when attempting to run
|
02bb0d6
to
b11867e
Compare
I pushed an update to the |
d175b3e
to
3a5cb08
Compare
Pushed an update that makes this PR compatible with another PR in review #18. Once reviewed/approved, either PR can now be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work, thanks for the contribution! Only non nit comment from me was to keep the version consistent with the technical preview release.
3fb3e17
to
44d19ba
Compare
Added a new commit that addressed feedback (thanks @graphcareful !). I also realized that |
Let me know if anyone thinks I should squash the commits and modify them so they make more sense based on what is changing in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @vuldin. My only comment is I think we should consolidate all Docker Compose examples in the same top-level directory. Happy to do it in this PR or a follow up PR.
- use wasm version of wasm-api client lib - switch to port 9092 (and similar ports for schema, pandaproxy, prometheus) for local/external connectivity - update README.md - remove upload-schemas.js (will be included in subsequent PR)
- move compose.yaml and redpanda.yaml into docker-compose directory (and rename files) - rebase from main branch (handle merge conflicts) - update docs to reflect updates from previous commits to main - add cleanup section to README
44d19ba
to
fb8259f
Compare
I've updated the branch with the following changes:
|
I don't like the commit history... I would like to have fixed that prior to a PR. But this PR has been around a while and review has already started, so I'm ok with keeping it as-is if everyone else is. |
This PR contains a few updates:
The updated README contains steps for running the app: https://github.com/vuldin/redpanda-examples/blob/wasm-example-improvements/wasm/js/transform_avro/README.md