Fix mutual TLS configuration with Console #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
changed the title
RafalKorepta
force-pushed
the
rk/K8S-261/mTLS-configuration
branch
from
d977a6c
to
4e432e7
Compare
chrisseto
approved these changes
Jul 12, 2024
RafalKorepta
force-pushed
the
rk/K8S-261/mTLS-configuration
branch
2 times, most recently
from
45e74a2
to
da07133
Compare
chrisseto
approved these changes
Jul 29, 2024
RafalKorepta
force-pushed
the
rk/K8S-261/mTLS-configuration
branch
7 times, most recently
from
5bc4c3f
to
c6e2ff6
Compare
The following panic was reported by end 2 end tests:
```
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x283b2ca]
goroutine 485 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x2c10280?, 0x50bf550?})
/root/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.4.linux-amd64/src/runtime/panic.go:770 +0x132
github.com/redpanda-data/redpanda-operator/src/go/k8s/internal/controller/redpanda.(*Reconciling).Do(0xc0009baee8, {0x3623e80, 0xc001555770}, 0xc000111808, 0x0, {{0x362e040?, 0xc000f1faa0?}, 0x4?})
/work/src/go/k8s/internal/controller/redpanda/console_controller.go:200 +0x52a
github.com/redpanda-data/redpanda-operator/src/go/k8s/internal/controller/redpanda.(*ConsoleReconciler).Reconcile(0xc000442a80, {0x3623e48?, 0xc000f1fa40?}, {{{0xc0013d11a0?, 0x5?}, {0xc001510840?, 0xc001dd1d10?}}})
/work/src/go/k8s/internal/controller/redpanda/console_controller.go:157 +0xb8d
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x362e040?, {0x3623e48?, 0xc000f1fa40?}, {{{0xc0013d11a0?, 0xb?}, {0xc001510840?, 0x0?}}})
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0009c81e0, {0x3623e80, 0xc00099d220}, {0x2d9ab20, 0xc001d337a0})
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:316 +0x3bc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0009c81e0, {0x3623e80, 0xc00099d220})
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266 +0x1be
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 196
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:223 +0x50c
```
The following line
```
ingressResource = ingressResource.WithTLS(resources.LEClusterIssuer, fmt.Sprintf("%s-redpanda", cluster.GetName()))
```
could only panic in the GetName function based on the stack trace.
As the verify-config.sh script fails with exit 1 if it exhausts all retires and kuttle does not move to next step that get-redpanda-info.sh script will be called when retires are exhausted. Ref https://buildkite.com/redpanda/redpanda-operator/builds/1812#0190abbe-38cd-41cf-8825-cf7a65b13505/4673-4716
End to end test shows the problem when broker configuration changes requires Redpanda process restart, but iterating over map is not deterministic. Order of creation that is defined in cluster_controller.go should be preserved in Ensure function. With that commit order will be preserved.
RafalKorepta
force-pushed
the
rk/K8S-261/mTLS-configuration
branch
3 times, most recently
from
fdfc490
to
35c44f1
Compare
All changes to the rpk config package are required, as this commit brings changes to go mod which updates rpk package. Reference #171
RafalKorepta
force-pushed
the
rk/K8S-261/mTLS-configuration
branch
from
35c44f1
to
f14c4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
redpanda-data/helm-charts#1348
redpanda-data/helm-charts#1402