Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk start: Allow passing --seeds and --advertised #125

Closed
0x5d opened this issue Nov 18, 2020 · 3 comments · Fixed by #173
Closed

rpk start: Allow passing --seeds and --advertised #125

0x5d opened this issue Nov 18, 2020 · 3 comments · Fixed by #173
Assignees
Labels

Comments

@0x5d
Copy link
Contributor

0x5d commented Nov 18, 2020

This will make it easier to run in general, but specifically in containers.

@0x5d 0x5d self-assigned this Nov 18, 2020
@0x5d 0x5d added the area/rpk label Nov 18, 2020
@0x5d
Copy link
Contributor Author

0x5d commented Nov 18, 2020

Being able to pass it through an env var is a requirement too.

@dotnwat
Copy link
Member

dotnwat commented Nov 18, 2020

@0x5d we don't have to be able to pass through environment variables, but we need to be able to configure the advertised host configuration when starting up a docker container.

here is an example using environment variables, but it would be completely reasonable to take arguments via command that'll get appended to the entrypoint.

  kafka-broker:
    image: vectorized/redpanda
    ports:
      - 9092:9092
    expose:
      - 29092
    environment:
      KAFKA_AUTO_CREATE_TOPICS_ENABLE: "false"
      KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
      KAFKA_LISTENERS: PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092
      KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://kafka-broker:29092,OUTSIDE://localhost:9092
      KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,OUTSIDE:PLAINTEXT
      KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT

@0x5d
Copy link
Contributor Author

0x5d commented Nov 19, 2020

I've been wanting to port the rpk config mgmt to Viper for the longest time. That will make this way easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants