Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redpanda should properly decode path parameters vs query parameters #16129

Closed
michael-redpanda opened this issue Jan 17, 2024 · 0 comments · Fixed by #16694
Closed

Redpanda should properly decode path parameters vs query parameters #16129

michael-redpanda opened this issue Jan 17, 2024 · 0 comments · Fixed by #16694
Assignees
Labels
area/admin-api kind/bug Something isn't working sev/medium Bugs that do not meet criteria for high or critical, but are more severe than low.

Comments

@michael-redpanda
Copy link
Contributor

michael-redpanda commented Jan 17, 2024

Version & Environment

Redpanda version: (use rpk version): all versions

What went wrong?

The + symbol is being improperly decoded to become a space character when it's found in a path parameter when path parameters are decoded using seastar's url decode method.

What should have happened instead?

Replacing a + with a space is valid for query parameters, but not path parameters. A + in the path should be left as is.

Need to create a path_decode method to be called specifically for path parameters.

Additional information

Related to #16124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin-api kind/bug Something isn't working sev/medium Bugs that do not meet criteria for high or critical, but are more severe than low.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants