Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade os for oss build #18027

Closed
wants to merge 6 commits into from
Closed

build: upgrade os for oss build #18027

wants to merge 6 commits into from

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Apr 23, 2024 •
edited

To move to clang 18

https://github.com/redpanda-data/redpanda/actions/runs/8803302480

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@rockwotj rockwotj requested a review from a team as a code owner April 23, 2024 15:36
@rockwotj rockwotj requested review from savex and removed request for a team April 23, 2024 15:36
dotnwat
dotnwat previously approved these changes Apr 23, 2024
View reviewed changes
@dotnwat
Copy link
Member

dotnwat commented Apr 23, 2024

Should we manually trigger the github action? I wonder if we can configure the action to auto-build if the action itself is changed and override the cron settings.

@rockwotj
Copy link
Contributor Author

Looks like we need to upgrade seastar first.

Error: https://github.com/redpanda-data/redpanda/actions/runs/8803302480/job/24161076495
Missing commit: scylladb/seastar@358fef9

@rockwotj
Copy link
Contributor Author

Should we manually trigger the github action?

Yeah I manually triggered. It's a shame that doesn't work from forks. I think enabling only if that workflow file changes SGTM

@savex
Copy link
Contributor

savex commented Apr 26, 2024

Something to consider here?
https://buildkite.com/redpanda/redpanda/builds/48328#018f1ab6-8870-4a42-a6a9-9b011310d2fc

@dotnwat
Copy link
Member

dotnwat commented Apr 29, 2024

Something to consider here? https://buildkite.com/redpanda/redpanda/builds/48328#018f1ab6-8870-4a42-a6a9-9b011310d2fc

what am i looking at here? smokecheck?

@rockwotj rockwotj requested a review from BenPope as a code owner April 30, 2024 03:16
@rockwotj
Copy link
Contributor Author

rockwotj commented Apr 30, 2024 •
edited

CI job: https://github.com/redpanda-data/redpanda/actions/runs/8888774493

@rockwotj rockwotj force-pushed the upgrade-oss-build branch 2 times, most recently from dfd5037 to b954b7f Compare April 30, 2024 03:24
@rockwotj
Copy link
Contributor Author

CI job: https://github.com/redpanda-data/redpanda/actions/runs/8888829020

@rockwotj
Copy link
Contributor Author

CI Job: https://github.com/redpanda-data/redpanda/actions/runs/8888849151

@rockwotj
Copy link
Contributor Author

Still need a seastar upgrade: https://github.com/redpanda-data/redpanda/actions/runs/8888849151/job/24406285151

BenPope
BenPope reviewed Apr 30, 2024
View reviewed changes
CMakeLists.txt Outdated
@@ -40,7 +40,8 @@ endif()
# creating a constexpr enum value that is bitwise combination
# of flags can trigger this warning as the resulting "enum",
# isn't a valid value.
add_compile_options(-Wno-enum-constexpr-conversion)
# TODO: Remove the no-vla-cxx-extension supression when seastar is upgraded.
Copy link
Member

@BenPope BenPope Apr 30, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more context here? (e.g., the commit that fixes this in seastar)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped this commit and just upgraded seastar :)

@savex
Copy link
Contributor

savex commented Apr 30, 2024

Something to consider here? https://buildkite.com/redpanda/redpanda/builds/48328#018f1ab6-8870-4a42-a6a9-9b011310d2fc

what am i looking at here? smokecheck?

Not sure, but it seems that Fedora 40 is not stable enough yet.

@rockwotj
cmake: upgrade seastar
0d4148b 
to fix warnings in the public build for clang 18

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
cmake/oss: fix ragel package in fedora 40
aa1ca75 
ragel-devel is dead, long live ragel!

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
gha: upgrade public build OS
8c735f1 
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

Kicked off a new CI run with the latest changes here: https://github.com/redpanda-data/redpanda/actions/runs/8899761789

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Apr 30, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/48528#018f3127-52b8-4377-a44e-f47678f3d6f9:

"rptest.tests.cloud_storage_scrubber_test.CloudStorageScrubberTest.test_scrubber.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/48548#018f323e-4a01-4550-a32e-4c006e9f2761:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48548#018f323e-4a05-40e7-9d34-080bcf8b9715:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48550#018f32af-2ee2-4073-84dd-52d4bf0e095d:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48550#018f32af-2ee6-4557-a4b4-ba136f830f6e:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48550#018f32ce-6948-42ef-acdd-9ced0f0dffa0:

"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/48550#018f32ce-6951-4a49-bb71-43e90455a668:

"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"

@rockwotj
cmake/seastar: disable deprecated declarations
d869028 
This mirrors the upstream commit: scylladb/seastar@6c450bf

Needed to build on ubuntu noble and clang-18

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
serde: remove c++23 feature detection
060c88f 
this causes issues until we upgrade to C++23

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
cmake: more aggresively silence warning
597b590 
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48550#018f32af-2ede-4add-875c-7c173df06e9b

@rockwotj rockwotj closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope left review comments

@dotnwat dotnwat dotnwat left review comments

@savex savex Awaiting requested review from savex savex is a code owner automatically assigned from redpanda-data/devprod

Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rockwotj @dotnwat @savex @vbotbuildovich @BenPope