Use tls socket to retrieve distinguished name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazin
commented
Apr 25, 2022
dotnwat
reviewed
Apr 26, 2022
There was a problem hiding this comment.
this looks awesome, and based on what I'd seen before in the TLS implementation it makes sense. I left a few comments / questions.
I guess in redpanda, src/v/net/server.cc - server::accept after we call accept on the socket we can co_await on the handshake / DN before setting up the final connection and handing it off to the protocol implementation (e.g. kafka).
tests/unit/tls_test.cc
Outdated
Comment on lines
1162
to
1171
| auto dn = fdn.get(); | ||
| BOOST_REQUIRE(dn.has_value()); | ||
| }); | ||
| }); | ||
|
|
||
| auto client_socket = tls::connect(cert_creds, addr).get(); | ||
| auto client_fin = client_socket.input(); | ||
| auto read_buf = client_fin.read_exactly(5).get(); | ||
| client_fin.close().get(); |
There was a problem hiding this comment.
Can we make this test a bit more sophisticated? Something that tests multiple clients and verifies the contents of the DN? I was thinking something like:
- generate server certs
- generate client1 certs with DN that contains some magic value 1 (e.g. some domain)
- generate client2 certs with DN that contains some magic value 2 (e.g. some other domain)
- start a server that writes the DN on its connection to the connection output
- each client connects, reads the output, verifies that it contains the expected magic value
src/net/tls.cc
Outdated
| @@ -1336,7 +1347,7 @@ class session : public enable_lw_shared_from_this<session> { | |||
| return make_exception_future<>(std::system_error(ENOTCONN, std::system_category())); | |||
| } | |||
| if (!_connected) { | |||
| return handshake().then([this, p = std::move(p)]() mutable { | |||
| return handshake().discard_result().then([this, p = std::move(p)]() mutable { | |||
There was a problem hiding this comment.
I'm not sure I understand why discard_result is used here. afaict handshake() already returns a future<>
There was a problem hiding this comment.
artefact from previous implementation
Lazin
force-pushed
the
feature/padd-dn-through-callback
branch
from
7ecfb52
to
3fac4fb
Compare
dotnwat
reviewed
Apr 27, 2022
Previously, it was possible to get DN using dn_callback passed to credentials object. This callback is invoked on every handshake (if 'client_auth' is set to true) and accepts two parameters, subject and issuer. But there is no way for the user of the tls library to connect particular client connection with the DN string. This commit adds a 'get_distinguished_name' method to connected socket interface. This commit can be used to wait on a future that returns a distinguished name or nullopt after a handshake. The handshake is performed asynchrnously. Because of that the retrieval of the DN string should also be asynchronous. This commit also adds a unit test and scripts that generate a bunch of certificates/keys for it.
Lazin
force-pushed
the
feature/padd-dn-through-callback
branch
from
3fac4fb
to
8fe5b6e
Compare
dotnwat
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible to get DN using dn_callback passed to
credentials object. This callback is invoked on every handshake (if
'client_auth' is set to true) and accepts two parameters, subject and
issuer. But there is no way for the user of the tls library to connect
particular client connection with the DN string.
This commit adds a 'get_distinguished_name' method to connected socket
interface. This commit can be used to wait on a future that returns a
distinguished name or nullopt after a handshake. The handshake is
performed asynchrnously. Because of that the retrieval of the DN string
should also be asynchronous.
This commit also adds a unit test and scripts that generate a bunch of
certificates/keys for it.