Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix reference link #818

Merged
merged 1 commit into from Dec 14, 2017
Merged

Conversation

takahi-i
Copy link
Member

Ref #816

@coveralls
Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage increased (+0.04%) to 91.346% when pulling 8b11d80 on takahi-i:hotfix-reference-link into e25d95b on redpen-cc:master.

@coveralls
Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage increased (+0.04%) to 91.346% when pulling 8b11d80 on takahi-i:hotfix-reference-link into e25d95b on redpen-cc:master.

@rhysd
Copy link

rhysd commented Dec 13, 2017

I'm sorry that I now don't have an environment to build Java application. Could you try this file and confirm no error? If no error, it must work for me.

@takahi-i
Copy link
Member Author

takahi-i commented Dec 14, 2017

Thank you very much for giving us the sample text @rhysd. I succeeded to run fixed redpen command for the sample.

Log

➜  redpen-distribution-1.10.1-SNAPSHOT git:(hotfix-reference-link) bin/redpen  ~/tmp/README.md
[2017-12-15 00:52:23.117][INFO ] cc.redpen.Main - Configuration file: /Users/takahi-i/IdeaProjects/redpen/redpen-distribution/target/redpen-distribution-1.10.1-SNAPSHOT/conf/redpen-conf-en.xml
[2017-12-15 00:52:23.125][INFO ] cc.redpen.config.ConfigurationLoader - Loading config from specified config file: "/Users/takahi-i/IdeaProjects/redpen/redpen-distribution/target/redpen-distribution-1.10.1-SNAPSHOT/conf/redpen-conf-en.xml"
[2017-12-15 00:52:23.139][INFO ] cc.redpen.config.ConfigurationLoader - Succeeded to load configuration file
[2017-12-15 00:52:23.139][INFO ] cc.redpen.config.ConfigurationLoader - Language is set to "en"
[2017-12-15 00:52:23.139][WARN ] cc.redpen.config.ConfigurationLoader - No variant configuration...
[2017-12-15 00:52:23.142][INFO ] cc.redpen.config.ConfigurationLoader - No "symbols" block found in the configuration
[2017-12-15 00:52:23.145][INFO ] cc.redpen.config.SymbolTable - Default symbol settings are loaded
[2017-12-15 00:52:23.153][INFO ] cc.redpen.parser.SentenceExtractor - "[., ?, !]" are added as a end of sentence characters
[2017-12-15 00:52:23.153][INFO ] cc.redpen.parser.SentenceExtractor - "[', "]" are added as a right quotation characters
[2017-12-15 00:52:23.563][WARN ] cc.redpen.parser.markdown.ToFileContentSerializer - Failed to add parent for a Section
[2017-12-15 00:52:23.662][INFO ] org.reflections.Reflections - Reflections took 50 ms to scan 1 urls, producing 6 keys and 58 values
[2017-12-15 00:52:23.751][WARN ] cc.redpen.validator.ValidatorFactory - cc.redpen.validator.sentence.SpaceBeginningOfSentenceValidator is deprecated
[2017-12-15 00:52:23.755][WARN ] cc.redpen.validator.ValidatorFactory - cc.redpen.validator.section.VoidSectionValidator is deprecated
[2017-12-15 00:52:23.809][INFO ] org.reflections.Reflections - Reflections took 3 ms to scan 1 urls, producing 175 keys and 180 values
[2017-12-15 00:52:24.011][INFO ] cc.redpen.util.DictionaryLoader - Succeeded to load UnexpandedAcronymValidator default dictionary.
[2017-12-15 00:52:24.016][INFO ] cc.redpen.util.DictionaryLoader - Succeeded to load weak expressions.
[2017-12-15 00:52:24.017][INFO ] cc.redpen.validator.JavaScriptValidator - JavaScript validators directory: js
README.md:81: ValidationError[UnexpandedAcronym], The expanded form of the acronym API is not present in the document. at line: MIT license
README.md:59: ValidationError[EmptySection], The section "How to get GitHub API token" is empty. at line: How to get GitHub API token
README.md:12: ValidationError[SentenceLength], The length of the sentence (121) exceeds the maximum of 120. at line: github-clone-all is a small command to clone all repositories matching to given query and language via GitHub Search API.
README.md:25: ValidationError[EndOfSentence], Found invalid end of sentence "'.". at line:  But quoting the query is recommended to avoid conflicting with shell special characters as github-clone-all 'foo bar'.
README.md:51: ValidationError[Hyphenation], This phrase should be hyphenated (ie: "set-to"). at line: If the token is set to $GITHUB_TOKEN environment variable, omitting -token should also work fine.
README.md:59: ValidationError[Hyphenation], This phrase should be hyphenated (ie: "How-to"). at line: How to get GitHub API token

[2017-12-15 00:52:24.051][ERROR] cc.redpen.Main - The number of errors "6" is larger than specified (limit is "1").


@takahi-i takahi-i merged commit e6dedf2 into redpen-cc:master Dec 14, 2017
@takahi-i takahi-i deleted the hotfix-reference-link branch December 14, 2017 16:00
@takahi-i
Copy link
Member Author

Merged the hotfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants