Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on DoubleNagation output style #878

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Conversation

norm-ideal
Copy link
Contributor

Updated the DoubleNegation output message that was a direct output of rule variable.

Former output:

二重否定がみつかりました "ExpressionRule{elements=[TokenElement{surface='ない', tags=[], offset=0, reading='ない'}, TokenElement{surface='こと', tags=[], offset=0, reading='こと'}, TokenElement{surface='も', tags=[], offset=0, reading='も'}, TokenElement{surface='ない', tags=[], offset=0, reading='ない'}]}"

New output:

二重否定がみつかりました。 "ないこともない"

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 91.407% when pulling cf5336a on norm-ideal:cleanup into 81fc86b on redpen-cc:master.

@takahi-i takahi-i self-requested a review July 23, 2020 13:41
@takahi-i
Copy link
Member

@norm-ideal Deeply sorry for the late response. Thank you very much for the valuable improvement as always!

@takahi-i takahi-i merged commit 4ea76e6 into redpen-cc:master Jul 23, 2020
@norm-ideal norm-ideal deleted the cleanup branch October 23, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants