Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that cdec classes can be included in Apache Joshua (Incubating) v6.1 Release #94

Closed
lewismc opened this issue Jun 5, 2017 · 14 comments

Comments

@lewismc
Copy link

lewismc commented Jun 5, 2017

Hi @armatthews @redpony @amittai @mjdenkowski we (the Apache Joshua (incubating) podling project management committee) are currently VOTE'ing on our 4th iteration of what we hope to be the first official Apache release of Joshua 6.1 (Incubating).
Within the release candidate review however, we've stumbled across an issue involving licensing of code which was taken from cdec. Specifically, the files are sentclient.cc and sentserver.cc. The issue is whether or not we can ship these files with the release. The crux of the issue is as follows

Both files are /* Copyright (c) 2001 by David Chiang. All rights reserved.*/

Just because these files were added to a repo that is under an Apache license 
(by someone other than the author I would note) doesn't automatically mean the 
original files were Apache licensed.

Perhaps the best thing to do is to reach to the author and ask for permission 
to use the files / clarify the license they are under?

Can someone please comment as to whether these files are licensed as Apache Licence v2.0 as would be indicated by LICENSE.txt?
Thank you in advance.

@redpony
Copy link
Owner

redpony commented Jun 6, 2017 via email

@lewismc
Copy link
Author

lewismc commented Jun 6, 2017

@redpony can you please tag him here? Thank you

@lewismc
Copy link
Author

lewismc commented Jun 9, 2017

@redpony sorry to be a PITA, can you please ping David here? Thank you kindly.

@kpu
Copy link
Collaborator

kpu commented Jun 9, 2017

E-mail him? https://www.nd.edu/~dchiang/

@lewismc
Copy link
Author

lewismc commented Jun 9, 2017

Thank you @kpu

@kpu
Copy link
Collaborator

kpu commented Jun 9, 2017

Paging @davidweichiang

@mjpost
Copy link

mjpost commented Jun 9, 2017

@lewismc, these were included long ago not via cdec but via Adam Lopez (a former colleague). However, they aren't really used by anything, and can be safely removed if you don't hear from David.

@davidweichiang
Copy link

Oh wow, glad someone is using my code. :) Since these were written when I was a student, I believe (but have not checked) that I am indeed the copyright holder, not the University of Pennsylvania. If that's the case, I'd be happy to license them under the Apache license.

@lewismc
Copy link
Author

lewismc commented Jun 9, 2017

Ok doke thank you for all the input.

@lewismc
Copy link
Author

lewismc commented Jun 9, 2017

Is there any ways for this to be checked out? I know it may be a bit of a pain, but we would rather include them than remove at this stage. Thanks again.

@davidweichiang
Copy link

davidweichiang commented Jun 9, 2017 via email

@lewismc
Copy link
Author

lewismc commented Jun 9, 2017

Yes Sir

@davidweichiang
Copy link

davidweichiang commented Jun 9, 2017 via email

@lewismc
Copy link
Author

lewismc commented Jun 10, 2017

Thank you very much @davidweichiang and others that participated here. Closing this as resolved.

@lewismc lewismc closed this as completed Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants