Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⛓️‍💥 Change the name of the argument line_breaks? #143

Closed
favonia opened this issue Nov 13, 2023 · 2 comments
Closed

⛓️‍💥 Change the name of the argument line_breaks? #143

favonia opened this issue Nov 13, 2023 · 2 comments
Labels
help wanted Extra attention is needed low priority question Further information is requested tty

Comments

@favonia
Copy link
Contributor

favonia commented Nov 13, 2023 •
edited
Loading

This is a minor issue, but I have been struggling with a good name for the argument to change the line breaking algorithm. It's taking `Traditional or `Unicode to indicate the mode:

val display : ... -> ?line_breaks:[`Unicode | `Traditional] -> ... -> Message.t Diagnostic.t -> unit

The ones coming into my mind include

  1. line_breaks
  2. line_breaking
  3. line_breaking_alg
  4. newlines

I wonder if some native speaker can help me out 😆
@favonia favonia added help wanted Extra attention is needed question Further information is requested low priority tty labels Nov 13, 2023
@TOTBWF
Copy link
Collaborator

TOTBWF commented Nov 13, 2023 •
edited
Loading

Either line_breaks or line_break_strategy. I prefer the former because it is shorter :)

@favonia
Copy link
Contributor Author

favonia commented Nov 13, 2023

Alright, I'll keep the current name line_breaks, then.

@favonia favonia closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
@favonia favonia changed the title ⛓️‍💥 The name of the argument line_breaks ⛓️‍💥 Change the name of the argument line_breaks? Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed low priority question Further information is requested tty
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@favonia @TOTBWF