Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set document.title from RCTF_NAME #27

Closed
ginkoid opened this issue Feb 16, 2020 · 3 comments
Closed

Set document.title from RCTF_NAME #27

ginkoid opened this issue Feb 16, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ginkoid
Copy link
Member

ginkoid commented Feb 16, 2020

At the moment, we are hardcoding document.title in the JS bundle:

rctf/client/src/config.js

Line 3 in ad637da

ctfTitle: ' | redpwnCTF 2020'

It would be better if we read this value from the RCTF_NAME env var instead.
@chen-robert chen-robert added enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2020
@pepsipu
Copy link
Member

pepsipu commented Mar 26, 2020

Not gonna lie homie but this do be looking kind of implemented here doe 😳 💯

@chen-robert
Copy link
Member

Yup, we just need to implement it on the client config as well, config/client.js.

@ethanwu10
Copy link
Member

Fixed by #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ethanwu10 @chen-robert @ginkoid @pepsipu